fix: WISH-453 Funding 및 Gift 서비스 리팩토링 및 이미지 매핑 로직 개선 #240
Merged
coding-jjun merged 6 commits intomainfrom Mar 9, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Funding 및 Gift 서비스의 코드 최적화 및 불필요한 로직 정리
주요 변경 사항:
Funding 서비스 개선
fundUser.image.imgUrl를imageManager.getImages()호출하지 않고 쿼리빌더 활용하여 성능 개선Gift 서비스 최적화
findAndCount()대신 쿼리빌더 활용하여 성능 개선기대 효과:
FROM
{ "fundId": 1, "fundUuid": "6558a6b6-c7b9-4047-9f33-2292c6830ea4", "fundUserId": 12, "fundUserNick": "032", "fundTitle": "제 생일을 축하해주세요 🥳", "fundCont": "아이폰이 갖고 싶습니다,,,", "fundTheme": "Birthday", "fundPubl": true, "fundGoal": 1200000, "fundSum": 0, "fundAddrRoad": "경기 성남시 분당구 판교역로 166", "fundAddrDetl": "1층", "fundAddrZip": "13529", "fundRecvName": "홍영의", "fundRecvPhone": "01056019638", "fundRecvReq": "집 앞에 놓아주세요", "regAt": "2025-03-05T01:39:13.229Z", "endAt": "2025-03-28", "gifts": [ { "giftId": 1, "fundId": 1, "giftUrl": "https://www.musinsa.com/products/4326317", "giftTitle": "아이폰 15", "giftOrd": 1, "giftOpt": "화이트", "giftCont": "", "giftImg": "https://mblogthumb-phimHHlmGOyrr6htAuxPETsg.8JJSQNEA5HX2WmrshjZ-VjmJWqhmgE40Qm5csIud9VUg.JPEG.minziminzi128/IMG_7374.JPG?type=w800" } ], "fundImgUrls": [], "fundUserImg": "http://t1.kakaocdn.net/account_images/default_profile.jpeg.twg.thumb.R110x110" }AFTER
{ "fundId": 1, "fundUuid": "6558a6b6-c7b9-4047-9f33-2292c6830ea4", "fundUserId": 12, "fundUserNick": "032", "fundTitle": "제 생일을 축하해주세요 🥳", "fundCont": "아이폰이 갖고 싶습니다,,,", "fundTheme": "Birthday", "fundPubl": true, "fundGoal": 1200000, "fundSum": 0, "fundAddrRoad": "경기 성남시 분당구 판교역로 166", "fundAddrDetl": "1층", "fundAddrZip": "13529", "fundRecvName": "홍영의", "fundRecvPhone": "01056019638", "fundRecvReq": "집 앞에 놓아주세요", "regAt": "2025-03-05T01:39:13.229Z", "endAt": "2025-03-28", "gifts": [ { "giftId": 1, "fundId": 1, "giftUrl": "https://www.musinsa.com/products/4326317", "giftTitle": "아이폰 15", "giftOrd": 1, "giftOpt": "화이트", "giftCont": "", "giftImg": "https://mblogthumb-phimHHlmGOyrr6htAuxPETsg.8JJSQNEA5HX2WmrshjZ-VjmJWqhmgE40Qm5csIud9VUg.JPEG.minziminzi128/IMG_7374.JPG?type=w800" } ], "fundImgUrls": [ // <------------------ 추가됨! "https://mblogthumb-phimHHlmGOyrr6htAuxPETsg.8JJSQNEA5HX2WmrshjZ-VjmJWqhmgE40Qm5csIud9VUg.JPEG.minziminzi128/IMG_7374.JPG?type=w800" ], "fundUserImg": "http://t1.kakaocdn.net/account_images/default_profile.jpeg.twg.thumb.R110x110" }리뷰 부탁드립니다. 🚀